1. Taro L. Saito
  2. sqlite-jdbc
  3. Pull requests

Pull requests

#14 Merged
Repository
xerial
Branch
default

Implement setEscapeProcessing() in Statement and ResultSet as no-op

Author
  1. Joel Carranza
Reviewers
Description

Fix for http://code.google.com/p/sqlite-jdbc/issues/detail?id=3

Changes made as requested

Comments (4)

  1. Grace Batumbya

    Thanks you for your contribution. Before it is accepted, please make the following changes:

    RS.java

    Changes are not required. setEscapeProcessing() is Statement method only

    Unused.java

    Change

        private SQLException unused() {
    

    to

    protected SQLException unused() {
    

    Stmt.java

    Wouldn't is be better if an error is throw when true is passed, seeing the driver does not implement escape processing. I suggest the following implementation

    if (enable){
         throw unused();
    }
    
  2. Joel Carranza author

    Changes made. Added a stupid simple test case as well.

    Glad to see you're closing out some of the pull requests. Thanks and keep up the good work!