Pull requests

#3 Open
Repository
bkaes
Branch
default
Repository
xi
Branch
default

Fix YAML_DECLARE macro for MINGW32 architecture.

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r default https://bitbucket.org/bkaes/libyaml
hg merge e332896044d7
hg commit -m 'Merged in bkaes/libyaml (pull request #3)'
Author
  1. Benjamin Kästner
Reviewers
Description

MinGW declares _WIN32. Since YAML_DECLARE_STATIC isn't declared before yaml.h is included, YAML_DECLARE will expand to

__declspec(dllexport) type

which doesn't work with MinGW, instead you would end up with undefined references to _impl__yaml_*. Checking whether you're currently in a MINGW32 setting fixes that behaviour.

  • Learn about pull requests

Comments (0)