Jason R. Coombs avatar Jason R. Coombs committed 6c0a9fd

Cache the channel listing because retrieval might be slow.

Comments (0)

Files changed (1)

pmxbot/logging.py

 import datetime
 import itertools
 import struct
+import threading
 
 import pytz
 
 		channel = channel.replace('#', '').lower()
 		self._message(channel, nick, msg)
 
+	def list_channels(self):
+		# channel listing can be expensive, so returned a cached result and
+		#  refresh the cache in the background.
+		def update_cache():
+			self._channel_cache = self._list_channels()
+		if not '_channel_cache' in vars(self):
+			update_cache()
+		else:
+			threading.Thread(target = update_cache).start()
+		return self._channel_cache
+
 init_logger = Logger.from_URI
 
 class SQLiteLogger(Logger, storage.SQLiteStorage):
 			alllines.extend(lines)
 		return matches
 
-	def list_channels(self):
+	def _list_channels(self):
 		query = "SELECT distinct channel from logs"
 		return (chan[0] for chan in self.db.execute(query).fetchall())
 
 			alllines.extend(context)
 		return matches
 
-	def list_channels(self):
+	def _list_channels(self):
 		return self.db.distinct('channel')
 
 	def last_message(self, channel):
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.