Jason R. Coombs avatar Jason R. Coombs committed 6c3cd77

Flat is better than nested

Comments (0)

Files changed (1)

pmxbot/commands.py

 	insre = re.compile('<div class="insult" id="insult">(.*?)</div>')
 	html = util.get_html(insurl)
 	insult = insre.search(html).group(1)
-	if insult:
-		if rest:
-			insultee = rest.strip()
-			karma.Karma.store.change(insultee, -1)
-			if instype in (0, 2):
-				cinsre = re.compile(r'\b(your)\b', re.IGNORECASE)
-				insult = cinsre.sub("%s's" % insultee, insult)
-			elif instype in (1, 3):
-				cinsre = re.compile(r'^([TY])')
-				insult = cinsre.sub(
-					lambda m: "%s, %s" % (
-						insultee, m.group(1).lower()), insult)
-		return insult
+	if not insult:
+		return
+	if rest:
+		insultee = rest.strip()
+		karma.Karma.store.change(insultee, -1)
+		if instype in (0, 2):
+			cinsre = re.compile(r'\b(your)\b', re.IGNORECASE)
+			insult = cinsre.sub("%s's" % insultee, insult)
+		elif instype in (1, 3):
+			cinsre = re.compile(r'^([TY])')
+			insult = cinsre.sub(
+				lambda m: "%s, %s" % (
+					insultee, m.group(1).lower()), insult)
+	return insult
 
 @command("compliment", aliases=('surreal',),
 	doc="Generate a random compliment from "
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.