Removing analysis modules as per Trello card

#1009 Merged at 7e7ef2a
Repository
yt-old
Branch
yt-3.0
Repository
yt
Branch
yt-3.0
Author
  1. John ZuHone
Reviewers
Description

This Trello card lists analysis modules to be removed:

https://trello.com/c/tJuM4kkk/23-remove-analysis-modules-as-needed

It appears hierarchy_subset is removed already.

UPDATE: yt.analysis_modules.api.py is now removed.

Comments (15)

  1. Britton Smith

    I think now is the time to get rid of yt/analysis_modules/api.py altogether. Importing all analysis modules just to get one thing is a bad idea.

  2. Nathan Goldbaum

    If we're removing the api.py file, can we also make sure to update the documentation where it is referenced?

    1. Nathan Goldbaum

      To be more specific, analysis_modules.api is referenced in the following locations in the docs:

      ./source/analyzing/analysis_modules/PPVCube.ipynb:
         24 :       "from yt.analysis_modules.api import PPVCube"
      ./source/analyzing/analysis_modules/SZ_projections.ipynb:
         94 :       "from yt.analysis_modules.api import SZProjection\n",
      ./source/analyzing/analysis_modules/absorption_spectrum.rst:
         38 :   from yt.analysis_modules.api import AbsorptionSpectrum
      ./source/analyzing/analysis_modules/light_ray_generator.rst:
         29 :   from yt.analysis_modules.api import LightRay
      ./source/analyzing/analysis_modules/photon_simulator.rst:
        389 :    from yt.analysis_modules.api import *
      ./source/analyzing/analysis_modules/planning_cosmology_simulations.rst:
         13 :   from yt.analysis_modules.api import CosmologySplice
      
      1. chummels

        I agree with @ngoldbaum . As long as we're wiping out the global analysis_modules api, we should just as well modify these docs to make sure they point to the right local api. Sorry to make more work, @jzuhone .

  3. John ZuHone author

    It turns out there are references to HaloProfiler in quite a few places in the docs. It looks like other analysis modules use it?

      1. John ZuHone author

        Then this should probably be a separate PR, done by someone with more knowledge of HaloProfiler.

        This should be ready to go then.