Be much more careful about assigning clump IDs.

#717 Declined
Repository
MatthewTurk
Branch
yt-3.0
Repository
yt_analysis
Branch
yt-3.0
Author
  1. MattT
Reviewers
Description

This may fix the issue Kacper was seeing. But, I want to wait on acceptance until he verifies that it does, and he creates a test that includes @hegan's script and his own.

Comments (11)

  1. MattT author

    @hegan if you apply this to the unitrefactor branch, you'll need to change "Ones" to "ones". "Contours" to "contours", too.

  2. Kacper Kowalik

    Unfortunately both scripts from issue #796 still fail for me :-/

    shakuras ~/yt/src/yt $ yt instinfo
    
    yt module located at:
        /home/xarth/yt/src/yt
    The supplemental repositories are located at:
        /home/xarth/yt/src/yt-supplemental
    
    The current version of the code is:
    
    ---
    f0afdef13a62
    ---
    
  3. MattT author

    So, I'm declining this PR. I have rebased the one commit on top of current, mainline yt-3.0, and the script @xarthisius posted in #796 works after a typo fix.

    @xarthisius in the new PR I'm opening, would you mind checking this?