Commits

Yuya Nishihara committed f1d6181

unmimic

Comments (0)

Files changed (1)

delete-dummyfinished.diff

 # HG changeset patch
-# Parent aab6acb5fff9ad8b36aa8e1f9d8ad7e9f1f64e7a
-TODO: delete imitated finished signals
+# Parent df08621f074b63051350df5621ee2d3020056574
+delete imitated finished signals
 
+diff --git a/tortoisehg/hgqt/filedialogs.py b/tortoisehg/hgqt/filedialogs.py
+--- a/tortoisehg/hgqt/filedialogs.py
++++ b/tortoisehg/hgqt/filedialogs.py
+@@ -72,7 +72,6 @@ class _FileDiffScintilla(Scintilla):
+             p.drawLine(0, y, viewport.width(), y)
+ 
+ class _AbstractFileDialog(QMainWindow):
+-    finished = pyqtSignal(int)
+ 
+     def __init__(self, repoagent, filename):
+         QMainWindow.__init__(self)
+@@ -95,10 +94,6 @@ class _AbstractFileDialog(QMainWindow):
+         self.setupViews()
+         self.setupModels()
+ 
+-    def closeEvent(self, event):
+-        super(_AbstractFileDialog, self).closeEvent(event)
+-        self.finished.emit(0)  # mimic QDialog exit
+-
+     @property
+     def repo(self):
+         return self._repoagent.rawRepo()
+diff --git a/tortoisehg/hgqt/manifestdialog.py b/tortoisehg/hgqt/manifestdialog.py
+--- a/tortoisehg/hgqt/manifestdialog.py
++++ b/tortoisehg/hgqt/manifestdialog.py
+@@ -23,7 +23,6 @@ class ManifestDialog(QMainWindow):
+     Qt4 dialog to display all files of a repo at a given revision
+     """
+ 
+-    finished = pyqtSignal(int)
+     linkActivated = pyqtSignal(QString)
+ 
+     def __init__(self, repoagent, rev=None, parent=None):
+@@ -58,7 +57,6 @@ class ManifestDialog(QMainWindow):
+     def closeEvent(self, event):
+         self._writesettings()
+         super(ManifestDialog, self).closeEvent(event)
+-        self.finished.emit(0)  # mimic QDialog exit
+ 
+     def _readsettings(self):
+         s = QSettings()
+diff --git a/tortoisehg/hgqt/workbench.py b/tortoisehg/hgqt/workbench.py
+--- a/tortoisehg/hgqt/workbench.py
++++ b/tortoisehg/hgqt/workbench.py
+@@ -34,7 +34,6 @@ class ThgTabBar(QTabBar):
+ 
+ class Workbench(QMainWindow):
+     """hg repository viewer/browser application"""
+-    finished = pyqtSignal(int)
+ 
+     def __init__(self, ui, repomanager):
+         QMainWindow.__init__(self)
+@@ -1216,8 +1215,6 @@ class Workbench(QMainWindow):
+         else:
+             self.storeSettings()
+             self.reporegistry.close()
+-            # mimic QDialog exit
+-            self.finished.emit(0)
+ 
+     def closeRepoTabs(self):
+         '''returns False if close should be aborted'''
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.