Commits

Yuya Nishihara committed 72f2e7a

email: add comment why it needs to load patchbomb extension on demand

Borrowed from
https://groups.google.com/d/msg/thg-dev/J3Zr5_iuwzk/b1ookxFky_wJ

  • Participants
  • Parent commits b4a4dc9
  • Branches stable

Comments (0)

Files changed (1)

File tortoisehg/hgqt/hgemail.py

         self._readsettings()
         QShortcut(QKeySequence('CTRL+Return'), self, self.accept)
         QShortcut(QKeySequence('Ctrl+Enter'), self, self.accept)
+
+        # The email dialog is available no matter if patchbomb extension isn't
+        # enabled.  The extension name makes it unlikely first-time users
+        # would discover that Mercurial ships with a functioning patch MTA.
+        # Since patchbomb doesn't monkey patch any Mercurial code, it's safe
+        # to enable it on demand.
         hglib.loadextension(self._ui, 'patchbomb')
 
     def closeEvent(self, event):