`hg flow feature finish` Should display a warning if users have uncommitted changes

David Ipsen avatarDavid Ipsen created an issue

I am suggesting that the feature/release finish command in hgflow warns users before committing any changes that they have.

It is unlikely that users would want to commit these changes before the finish operation is completed, and this could lead to users erroneously committing changes that they did not mean to include in the merged result (as was the case for me).

If required, feature/release finish with a -f could force the release?

Comments (6)

  1. Yujie Wu

    I agree with you. The behavior is due to a bug, not by design. We shouldn't finish a branch if it is still dirty (IOW, having uncommitted changes). If the changes are meant to be committed, user can use hg flow <stream> finish -c, where the -c option will let hgflow commit the changes before finishing the branch.

  2. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.