33b9dea·Author: Samuel Cupp·Closed by: Samuel Cupp·2023-10-10
Description
Seed_Magnetic_Fields change for GRHayL compatibility
The scheduling for this thorn was explicitly dependent on IllinoisGRMHD despite being only acting on HydroBase. To keep codes independent, enforcing that this happens `before HydroBase_Prim2ConInitial` allows for more codes to use this thorn.
Combined Seed_Magnetic_Fields and Seed_Magnetic_Fields_BNS There’s no reason for these to be two different thorns. This combines them, cleans up some formatting, and introduces the needed parameters to switch between them. Most changes to the TOV code are explicitly declaring variables as const and formatting.
ID_converter_GiRaFFE bug fix
ID_converter_GiRaFFE also had incorrect scheduling, depending on Convert_to_HydroBase instead of GiRaFFE_to_HydroBase. Correct function ordering previously would be coincidence/luck.
Seed_Magnetic_Fields change for GRHayL compatibility
The scheduling for this thorn was explicitly dependent on IllinoisGRMHD despite being only acting on HydroBase. To keep codes independent, enforcing that this happens `before HydroBase_Prim2ConInitial` allows for more codes to use this thorn.
Combined Seed_Magnetic_Fields and Seed_Magnetic_Fields_BNS
There’s no reason for these to be two different thorns. This combines them, cleans up some formatting, and introduces the needed parameters to switch between them. Most changes to the TOV code are explicitly declaring variables as const and formatting.
ID_converter_GiRaFFE bug fix
ID_converter_GiRaFFE also had incorrect scheduling, depending on Convert_to_HydroBase instead of GiRaFFE_to_HydroBase. Correct function ordering previously would be coincidence/luck.
Â