1. Zikzakmedia 100% GPL
  2. trytond-network
  3. Pull requests

Pull requests

#1 Open
Repository
jesusnan
Branch
default
Repository
zikzakmedia
Branch
default

Redesigned module.

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r default https://bitbucket.org/jesusnan/trytond-network
hg merge ece89b661f54
hg commit -m 'Merged in jesusnan/trytond-network (pull request #1)'
Author
  1. Jesús Martín (NaN·tic)
Reviewers
Description

Included almost all reviews

  • Learn about pull requests

Comments (5)

  1. Jordi Esteve (Zikzakmedia)

    I don't see any methods with "2" prefix. Only some classes with "2" suffix, like class Network2: This is correct, for ex. it is used in the account official module.

    I think at this moment sql migration is not important because almost nobody uses it in a production environment.

    The name of the tabs (Networks, Hardware, Softwares) are not translated.

    It is impossible to change the party of a network with hardwares, because the conditions of the domains. They check that a network can only have hardwares of the same party, and vice-versa. Two solutions:

    1) Domains more flexible. Allow a network can have hardwares of the different party, and vice-versa. I some business, like server hostings, the network and the hardware can belong to different parties.

    2) Change the party field in hardware to a functional field that shows the party of one of the networks it belongs.

    I prefer solution 1).

    I suggest to add a party field in software: a functional field that shows the party of the hardware it belongs. And add it to tree and form views. This will allow to filter software by party.

    In Networks, Addresses and Hardwares tabs are very similar. Could be possible to see only one tab with address+hardware information? In Hardwares, Addresses and Networks tabs are very similar. Could be possible to see only one tab with address+network information? It not, it is better to put the Addresses and Networks tabs together, and then the Softwares tab.

    Is it possible to change or extend the hardware and software types? I don't see any configuration menu.

  2. Jesús Martín (NaN·tic) author

    Jordi said:

    "It is impossible to change the party of a network with hardwares, because the conditions of the domains. They check that a network can only have hardwares of the same party, and vice-versa. Two solutions:

    1) Domains more flexible. Allow a network can have hardwares of the different party, and vice-versa. I some business, like server hostings, the network and the hardware can belong to different parties.

    2) Change the party field in hardware to a functional field that shows the party of one of the networks it belongs.

    I prefer solution 1)."

    But I understand that it is a required condition in order to be sure of the security of the network. Otherwise, we could find that, if we have hardwares of more than a unique company in the same network, it could be possible to connect computers between these companies. I think this is an important security hole, so to avoid it, we must be sure that all hardwares connected to a network, are from the same party.

  3. Jesús Martín (NaN·tic) author

    Jordi said:

    "Is it possible to change or extend the hardware and software types? I don't see any configuration menu."

    There aren't any hardware type table, it is only a Selection field in the hardware.hardware model. Do you prefer to have a table instead?