runEditor does not work on Windows

Issue #18 resolved
Ross Light
repo owner created an issue

There are two parts of editor.go that assume a UNIX-like environment:

  • Starting the editor uses sh for command-line parsing
  • shellEscape uses single quotes (which cmd.exe does not like)

Need to create an editor_windows.go and an editor_windows_test.go.

Comments (3)

  1. Ross Light reporter

    Support runEditor on Windows (fixes #18)

    Add windowsEscape and a variant inside runEditor to support this fix.

    I initially wrote this in a platform-specific file, but found that the code was more similar than different. Neither of these require platform-specific packages and both use os/exec.

    → <<cset 315e5db526b1>>

  2. Log in to comment