Issue #1 resolved

dubious vec64.Vector.Vec3

binet
created an issue

hi,

briefly skimming over the code, I see:

https://bitbucket.org/zombiezen/math3/src/8a28f5726d31c8296abeadc6a140ade14dc00b07/vec64/vec64.go?at=default#cl-12

// Vec3 returns a copy of the vector with the 4th component set to zero.
func (v Vector) Vec3() Vector {
        return Vector{v[0], v[1], v[2], v[3]}
}

that doesn't look quite in line with the comment.

should this read, instead:

// Vec3 returns a copy of the vector with the 4th component set to zero.
func (v Vector) Vec3() Vector {
        return Vector{v[0], v[1], v[2], 0.}
}

?

-s

Comments (2)

  1. Log in to comment