11ad2a8·Author: Mike Bayer·Closed by: Mike Bayer·2016-03-16
Description
The batch implementation of drop_column doesn't pass the MS SQL-specific kwargs to the regular implementation. This means it is very impractical to create a migration that, for example, drops an Enum column (with its associated CHECK constraint), which would run both on MS SQL, and on SQLite (one would need to special-case one of the backends in the migration).
This patch accepts the extra kwargs, and adds tests for the batch operation against MS SQL. All tests pass against SQLite and MS SQL. (I don't have any other backend set up on this machine.)
The batch implementation of drop_column doesn't pass the MS SQL-specific kwargs to the regular implementation. This means it is very impractical to create a migration that, for example, drops an Enum column (with its associated CHECK constraint), which would run both on MS SQL, and on SQLite (one would need to special-case one of the backends in the migration).
This patch accepts the extra kwargs, and adds tests for the batch operation against MS SQL. All tests pass against SQLite and MS SQL. (I don't have any other backend set up on this machine.)