Pull requests

#11 Merged
Repository
jvanasco jvanasco
Branch
master
Repository
zzzeek zzzeek
Branch
master

memory_pickle backend support

Author
  1. jvanasco avatarjvanasco
Reviewers
Description

refactored the suggested MemoryPickleBackend into a subclass of MemoryBackend ; an internal flag in the class decides if we pickle or not.

Also updated the get_multi and set_multi in MemoryBackend to just proxy multiple calls to get/set. This simplified the readability and code organization, though there will be a slight performance drop ( multiple function calls vs direct dictionary access ).

added the generic test case; it passes.

did not commit the ( 2 line addition ) to docs, as it was marked in git-ignore.

Comments (4)

  1. Mike Bayer repo owner

    yeah whats up with the .gitignore, I think because "build/" is in the file it blocks "docs/build" ? whats the correct format for that, I just want the root "build/" in .gitignore

  2. jvanasco author

    updated.

    sorry about the PEP. when my eyes are tired (like today) I make egregious use of whitespace , so i can focus on the content better. i forgot to clean that out.

    i updated the .gitignore ; you may want to reject the changes.

    the ignore syntax is weird, because it seems to apply the gitignore file to every item in a directory -- the paths of elements of the files are essentially relative, not absolute.:

    • ending a line entry with "/" specifies that it is a directory , but...
    • patterns generally match for all entities under the root. so...
    • build/ blocks out every build subdirectory, just like 'README' blocks out every README file.
    • if you want to block out a specific build directory, or file, then you do /README or /path/to/build/

    thought of differently, unless you explicitly start with '/', it treats everything as a relative pattern, not absolute to the root path of the repo.

    at least that's my general understanding, and stackoverflow seems to confirm it.

Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.