1. Michael Bayer
  2. dogpile.cache
  3. Pull requests

Pull requests

#10 Merged

Pass the original key to the async creator so we don't mangle it twice

  1. Ryan Kolak

In it's current form, stale values will continue to be returned, and on every request the new value will be recomputed and stored under a new hashed key.

This fixes the issue by storing the unmangled key and passing that as the key to the async creator function.

Comments (4)

  1. Michael Bayer repo owner

    OK...just noticed that the async_creation_runner feature somehow got merged without any kind of test, not even something mock based. I'd really like some kind of rudimentary test suite in place for it, I'm not too eager to start committing fixes without being able to cover them.

  2. Ryan Kolak author

    Fine by me... I just wanted to flag this upstream since it will likely bite someone else.

    I'm using my fork of this in a project, and will be adding support for umemcache as a backend since pylibmc blocks under gevent and python-memcached leaves a bit to be desired in the performance area.

  3. Michael Bayer repo owner

    was hoping you had the motivation to write me some tests :) ....otherwise I have to get around to it. I've got a real backlog of pullrequests piling up...