Better Logging - adding support for dogpile cache keys on dogpile locks [dogpile.cache]

#27 Declined
Repository
jvanasco
Branch
better_logging
Repository
zzzeek
Branch
master
Author
  1. jvanasco
Reviewers
Description

re: https://bitbucket.org/zzzeek/dogpile.cache/issue/19/better-debug-logging

this failed a test_backend_dbm test at first, then it magically passed on every other run.

i had to symlink this against my patched dogpile.core to run

Comments (4)

  1. Michael Bayer repo owner

    I'm doing some dogpile PRs right now but this one has the dogpile.core dependency... ugh :) the setup.py here would need an update to point to the newer dogpile.core, which should be releaesd first, and there should be a test here.

  2. jvanasco author
    1. Agreed on this requiring the a minimum-version. I didn't know how to note that though :(

    2. I can throw together a test. I think it would probably just be ensuring the args work. not sure how/if i can check that something was logged. i'll look into that.