1. Michael Bayer
  2. dogpile.cache
  3. Pull requests

Pull requests

#37 Merged
Repository
fritsstegmann
Branch
master
Repository
zzzeek
Branch
master

Unit tests are passing with the time in the mem cache lib

Author
  1. Frits Stegmann
Reviewers
Description

Hi I have noticed that another developer create a pull request(https://bitbucket.org/zzzeek/dogpile.cache/pull-requests/31/add-in-timeout-for-memcache-distributed/diff) but it was never merged. I am keen to have this feature as part of the main repo. I have fixed some of the unit tests and they are all passing at the moment. I would love some feedback and guidance on getting this through review. I've felt the need to add a function to the backend to indicated if is supports a lock timeout or not. I've added some additional code in test_threaded_dogpile to check that dogpile returns a false when a lock timeout is supported.

Comments (3)

  1. Michael Bayer repo owner

    looks great, I really have to find time to get to a general backlog of code-oriented PRs but I have this in my primary inbox e.g. on the short list.