Commits

Mike Bayer committed d64ab47

correct for missing fail() methods which were lost when we removed unittest.TestCase

Comments (0)

Files changed (1)

test/ext/test_associationproxy.py

 
         self.assert_(p1.children == set(['a', 'b', 'c']))
 
-        try:
-            p1.children.remove('d')
-            self.fail()
-        except KeyError:
-            pass
+        assert_raises(
+            KeyError,
+            p1.children.remove, "d"
+        )
 
         self.assert_(len(p1.children) == 3)
         p1.children.discard('d')
 
         # We didn't provide an alternate _AssociationList implementation
         # for our ObjectCollection, so indexing will fail.
+        assert_raises(
+            TypeError,
+            p.children.__getitem__, 1
+        )
 
-        try:
-            v = p.children[1]
-            self.fail()
-        except TypeError:
-            pass
 
 class ProxyFactoryTest(ListTest):
     def setup(self):
         p = Parent('p')
 
         # No child
-        try:
-            v = p.foo
-            self.fail()
-        except:
-            pass
+        assert_raises(
+            AttributeError,
+            getattr, p, "foo"
+        )
 
         p.child = Child(foo='a', bar='b', baz='c')
 
         p.child = None
 
         # No child again
-        try:
-            v = p.foo
-            self.fail()
-        except:
-            pass
+        assert_raises(
+            AttributeError,
+            getattr, p, "foo"
+        )
 
         # Bogus creator for this scalar type
-        try:
-            p.foo = 'zzz'
-            self.fail()
-        except TypeError:
-            pass
+        assert_raises(
+            TypeError,
+            setattr, p, "foo", "zzz"
+        )
 
         p.bar = 'yyy'