1. Michael Bayer
  2. sqlalchemy
  3. Issues


Issue #1470 resolved

change dont_load=True to load=False

Anonymous created an issue

It isn't poor style to not eschew boolean variables that don't read in the negative.

Wouldn't e.g. "load=False" read less poorly than "dont_load=True"? Semantics are not lost, and you don't miss the bonus of not needing to munge the English.

Comments (6)

  1. Anonymous

    It probably seems more descriptive because you're expressing the exception to the rule.

    grep also reveals dont_expire_missing and dont_instrument (no_instrument), and there may well be other with more subtle names.

  2. Log in to comment