1. Michael Bayer
  2. sqlalchemy
  3. Issues

Issues

Issue #3090 resolved

Parameter order wrong for SQLite request

mike_solomon
created an issue

The following code fails to compile for SQLite with the correct parameter order. The user-defined callback function "pow" shows the wrong arguments coming in (strings instead of numbers). These strings are used as positional arguments elsewhere in the statement.

Sorry that I can't get it any smaller than this, but for the smaller examples I concocted SQLAlchemy gets things right so it is difficult to isolate the problem.

from sqlalchemy import Table, MetaData, Column, Integer, Float, String
from sqlalchemy import select
from sqlalchemy import and_, or_
from sqlalchemy import func
from plain import *

_metadata = MetaData()

def make_table(name, tp) :
  return Table(name, _metadata,
                     Column('id', Integer, primary_key = True),
                     Column('val', tp))

class JoinK(object) :
  def __init__(self, table) :
    self.table = table

class Join(JoinK) : pass
class Outerjoin(JoinK) : pass

def easy_sj(l, use_id = False, extras=[]) :
  to_join = filter(lambda x : isinstance(x, Table) or isinstance(x,JoinK), l)
  return easy_join(easy_select(l, use_id), to_join + extras)

def easy_select(l, use_id = False) :
  vals = [(t if not isinstance(t,Table) else t.c.val.label(t.name+'_val')) for t in l]
  if use_id :
    vals = [l[0].c.id.label('id')] + vals
  return select(vals)

def easy_join(stmt, lTables) :
  joins = lTables[0]
  for table in lTables[1:] :
    joink = table if isinstance(table, JoinK) else Join(table)
    joins = getattr(joins, 'join' if isinstance(joink, Join) else 'outerjoin' )(joink.table, onclause = joink.table.c.id == lTables[0].c.id)
  return stmt.select_from(joins)

def and_eq(table1, table2, vals) :
  return and_(*[table1.c[x] == table2.c[x] for x in vals])

def product(row) :
  return func.round(func.exp(func.sum(func.log(1.0 * row))))

Score = make_table('score', Integer)
Staff = make_table('staff', Integer)
Voice = make_table('voice', Integer)
Time_next = make_table('next', Integer)
Dots = make_table('dots', Integer)
Onset = make_table('onset', Float)  
Duration = make_table('duration', Float)
Duration_log = make_table('duration_log', Integer)
Name = make_table('name', String(50))
Numerator = make_table('numerator', Integer)
Denominator = make_table('denominator', Integer)
Left_bound = make_table('left_bound', Integer)
Right_bound = make_table('right_bound', Integer)

def make_statement(score, voice, name, left_bound, right_bound, duration_log, time_next, dots) :

  tuplets = easy_sj([score, voice, name, left_bound, right_bound,
                     Numerator, Denominator],
                    use_id = True).\
              where(name.c.val == "tuplet").\
              cte("tuplets")

  rhythmic_events = easy_sj([score, voice, Onset, duration_log],
                            use_id = True,
                            extras=[name]).\
                      where(or_(name.c.val == "chord",
                                name.c.val == "rest",
                                name.c.val == "space")).\
                      cte(name = "rhythmic_events")


  first_rhythmic_events = select([rhythmic_events.c.score_val,
                                  rhythmic_events.c.voice_val,
                                  func.max(rhythmic_events.c.onset_val).label('onset_val')]).\
                            group_by(rhythmic_events.c.score_val,
                                     rhythmic_events.c.voice_val).\
                            cte(name = "first_rhythmic_events")

  first_rhythmic_events_to_ids =\
       select([rhythmic_events.c.id,
               rhythmic_events.c.score_val,
               rhythmic_events.c.voice_val,
               rhythmic_events.c.onset_val]).\
         select_from(first_rhythmic_events.\
           join(rhythmic_events,
             onclause = and_eq(rhythmic_events,
                               first_rhythmic_events,
                               ['score_val', 'voice_val', 'onset_val']))).\
           cte("first_rhythmic_events_to_ids")

  rhythmic_events_to_tuplets =\
    select([rhythmic_events.c.id.label('rhythmic_id'),
            tuplets.c.id.label('tuplet_id'),
            tuplets.c.left_bound_val.label('left_val'),
            tuplets.c.right_bound_val.label('right_val')]).\
      where(and_eq(rhythmic_events, tuplets, ['score_val', 'voice_val'])).\
      cte(name = "rhythmic_events_to_tuplets", recursive = True)

  rhythmic_events_to_tuplets_a = rhythmic_events_to_tuplets.alias(name="rhythmic_events_to_tuplets_prev")

  rhythmic_events_to_tuplets =\
    rhythmic_events_to_tuplets.union_all(
      select([rhythmic_events_to_tuplets_a.c.rhythmic_id,
              rhythmic_events_to_tuplets_a.c.tuplet_id,
              time_next.c.val,
              rhythmic_events_to_tuplets_a.c.right_val]).\
      where(and_(time_next.c.val == rhythmic_events_to_tuplets_a.c.left_val,
                 time_next.c.val != rhythmic_events_to_tuplets_a.c.right_val)))

  rhythmic_events_to_matching_tuplets =\
    select([rhythmic_events_to_tuplets.c.rhythmic_id,
            product(tuplets.c.numerator_val).label('combined_numerator'),
            product(tuplets.c.denominator_val).label('combined_denominator')]).\
      select_from(rhythmic_events_to_tuplets.\
        join(tuplets, onclause = tuplets.c.id == rhythmic_events_to_tuplets.c.tuplet_id)).\
      where(rhythmic_events_to_tuplets.c.rhythmic_id ==\
            rhythmic_events_to_tuplets.c.left_val).\
      group_by(rhythmic_events_to_tuplets.c.rhythmic_id).\
      cte(name="rhythmic_events_to_matching_tuplets")

  rhythmic_events_to_durations =\
    select([duration_log.c.id,
            ((1.0 * func.ifnull(rhythmic_events_to_matching_tuplets.c.combined_numerator, 1.0) /\
                   func.ifnull(rhythmic_events_to_matching_tuplets.c.combined_denominator, 1.0)) *\
             (1.0 + ((func.pow(2, func.ifnull(dots.c.val, 0)) - 1) / func.pow(2, func.ifnull(dots.c.val,0)))) *\
             func.pow(2, duration_log.c.val))]).\
      select_from(duration_log.\
        outerjoin(rhythmic_events_to_matching_tuplets, onclause = duration_log.c.id == rhythmic_events_to_matching_tuplets.c.rhythmic_id).\
        outerjoin(dots, onclause = dots.c.id == duration_log.c.id))

  return rhythmic_events_to_durations

if __name__ == "__main__" :
  import math
  from properties import *
  from sqlalchemy import create_engine
  stmt = make_statement(score = Score,
                        voice = Voice,
                        name = Name,
                        left_bound = Left_bound,
                        right_bound = Right_bound,
                        duration_log = Duration_log,
                        time_next = Time_next,
                        dots = Dots)
  #print stmt

  engine = create_engine('sqlite:///:memory:', echo=False)
  conn = engine.connect()
  def my_log(in_val) :
    print in_val, "log"
    return math.log(in_val)
  def my_exp(x) :
    print in_val, "exp"
    return math.log(in_val)
  def my_pow(in_val_0, in_val_1) :
    print in_val_0, in_val_1, "pow", type(in_val_0)
    return in_val_0 ** in_val_1
  conn.connection.create_function("log",
                                  1,
                                  my_log)
  conn.connection.create_function("exp",
                                  1,
                                  my_exp)
  conn.connection.create_function("pow",
                                  2,
                                  my_pow)
  Score.metadata.create_all(engine)
  stmts = []
  for x in range(32) :
    stmts.append(Score.insert().values(id=x, val=0))
    stmts.append(Voice.insert().values(id=x, val=x%2))
    stmts.append(Duration_log.insert().values(id=x, val=-2))
  for st in stmts :
    conn.execute(st)
  #print stmt
  for row in conn.execute(stmt).fetchall() :
    print row

Comments (12)

  1. Michael Bayer repo owner

    'user-defined callback function "pow" ' do you mean my_pow()? which cases fail here? removing just a single one of these CTEs and the whole thing passes? Is it possible you can work with "echo=True" to inspect the arguments at that level, rather than waiting for a query to fail, such that you can reduce the complexity here? otherwise this is a ton of work for me to sort through obviously. The CTE-related ordering bugs are pretty simple, this is definitely 0.9.4 right?

  2. mike_solomon reporter

    The problem is that the whole large query is getting passed at once.

    It'll take me time to try to whittle it down: I've moved onto postgresql just to get it to work. I'm on a tight deadline, but as soon as I get the project in the can, I will be able to help debug!

  3. Log in to comment