bulk_save_objects now orders the object list before performing the groupby
Alessandro Cucci
Branch: alessandrocucci/sqlalchemy:master
Branch: zzzeek/sqlalchemy:master
Declined
Declined pull request
Dear contributor - This pull request is being moved to Gerrit, at https://gerrit.sqlalchemy.org/#/c/zzzeek/sqlalchemy/+/859, where it may be tested and reviewed more closely. As such, the pull request itself is being marked "closed" or "declined", however your contribution is merely being moved to our central review system. Please register at https://gerrit.sqlalchemy.org#/register/ to send and receive comments regarding this item.
Closed by: Mike Bayer·2018-08-25
The bulk_save_objects method is now doing a groupby without sorting the iterable first. This results in a lot of unnecessary loops which can be avoided. The proposed solution is to sort the object list before performing the groupby function.