flip around "returns_rows_text()" to "should_close_cursor()" - grep for UPDATE/INSERT/DELETE only

Issue #1212 resolved
Mike Bayer repo owner created an issue

we've been doing this the wrong way. returns_rows_text() is only used by ResultProxy to autoclose the cursor, which is not absolutely necessary since garbage collection will close it in any case. we can't keep expanding dialects to support more and more statements which return rows so we should have "autoclose" act upon a limited set of statements, not all statements which don't correspond to X.

Comments (3)

  1. Mike Bayer reporter

    also let's maintain backwards compatibility, i.e. for the DB2 dialect, by calling not returns_rows_text() as a fallback for should_close_cursor().

  2. Mike Bayer reporter

    this is fixed as of the latest trunk. The whole returns_rows thing is out, we just use cursor.description now.

  3. Log in to comment