MSDate, MSTime completely broken for pyodbc

There is no test coverage for the MSSQL DATE or TIME type at all. the server_version_info attribute is incorrectly used here:

if self.server_version_info < (10,):
    self.colspecs = MSSQLDialect.colspecs.copy()
    self.ischema_names = MSSQLDialect.ischema_names.copy()
    self.ischema_names['date']('date') = MSDateTimeAsDate
    self.colspecs[sqltypes.Date](sqltypes.Date) = MSDateTimeAsDate
    self.ischema_names['time']('time') = MSDateTimeAsTime
    self.colspecs[sqltypes.Time](sqltypes.Time) = MSDateTimeAsTime

server_version_info is a method requiring a connection, so the above always takes place, and MSDateTimeAsDate/Time are always used - DDL for DATE and TIME is never issued.

So removing the code above allows the tests in testtypes.py to actually create DATE and TIME columns. You need to use the same bind parameter processing on MSDate and MSTime as that of MSDateTimeAsDate, etc. For result processing, pyodbc returns a string for each of DATE and TIME:

Row (7, 'jack', datetime.datetime(2005, 11, 10, 0, 0), u'2005-11-10', u'12
:20:02.0000000')
Row (8, 'roy', datetime.datetime(2005, 11, 10, 0, 0), u'2005-10-10', u'00:
00:00.0000000')
Row (9, 'foo', datetime.datetime(2005, 11, 10, 0, 0), u'1970-04-01', u'23:
59:59.0000000')

So the MSDate and MSTime types require string parsing on the result side in order to function properly. tested with MS2008 and the latest pyodbc.

I'm not even sure if I want to target this for 0.5, and for 0.6 I think we might want to table ADODBAPI and PYMSSQL support completely since I don't have the bandwidth to address all three DBAPIs.

Comments (8)