When using convert_unicode=True, regular select returns unicode, but select distinct does not.

[Former user]

When using convert_unicode=True, regular select returns unicode, but select distinct does not.

# Normal select returns unicode
sql.select([t.c.text](t.c.text))

# Select distinct does not return unicode
sql.select([t.c.text.distinct()](t.c.text.distinct()))

See attached code. Only tested with postgres. Probably not a problem on sqlite if pysqlite converts all strings to unicode.

[Mike Bayer]

heres a possible patch:

Index: lib/sqlalchemy/sql/expression.py
===================================================================
--- lib/sqlalchemy/sql/expression.py    (revision 5974)
+++ lib/sqlalchemy/sql/expression.py    (working copy)
@@ -400,9 +400,9 @@

 def distinct(expr):
     """Return a ``DISTINCT`` clause."""
+    expr = _literal_as_binds(expr)
+    return _UnaryExpression(expr, operator=operators.distinct_op, type_=expr.type)

-    return _UnaryExpression(expr, operator=operators.distinct_op)
-
 def between(ctest, cleft, cright):
     """Return a ``BETWEEN`` predicate clause.

@@ -1477,7 +1477,7 @@
     def distinct(self):
         """Produce a DISTINCT clause, i.e. ``DISTINCT <columnname>``"""

-        return _UnaryExpression(self, operator=operators.distinct_op)
+        return _UnaryExpression(self, operator=operators.distinct_op, type_=self.type)

     def between(self, cleft, cright):
         """Produce a BETWEEN clause, i.e. ``<column> BETWEEN <cleft> AND <cright>``"""

[Mike Bayer]

that patch wasn't quite the issue, it was the result_map not getting populated (alternatively the unary expression could issue an ANON label but letting col naming goes through is nicer). Fixed in 4d036d6dd4a6dde9e7ae18ebc6451fdf8da0c726

[Mike Bayer]

Removing milestone: 0.5.6 (automated comment)