don't expand format string params - let the logging module do that

[Former user]

Instead of expanding format strings like this:

repr(..), str(...), or "foo %s" % (arg,)

rely on the logging module to do that for us. Bonuses include slightly less code and the format strings aren't expanded unless the log line should be generated - good for performance, too.

[Former user]

patch against HEAD

[Mike Bayer]

you forgot:

    def log(self, msg, *args):
        self.logger.info(msg, *args)

in pool.py.

you can run tests with all logging turned on via nosetests --log-debug=sqlalchemy.

after that the patch is great and in r6962, thanks.

[Former user]

(original author: ged) I guess you mean 8b74ddd791783ecbbae21d20da9f988b6ac1fcc6.

[Mike Bayer]

oops, thanks !

[Mike Bayer]

Removing milestone: 0.6.0 (automated comment)