Engine logger names are unpredictable

[Former user]

An engine logger's name is based on the engine's instance ID. This makes it impossible to preconfigure certain engines in a Python log-configure file because the engine has not been created. An example would be to silence an oververbose engine while logging most engines.

If create_engine took a 'name' argument, that name could be used in the logger name, which would make it predictable. Example:

engine = create_engine("mysql://...", name="stats")

[logger_stats](logger_stats)
level = WARN
handlers =
qualname = sqlalchemy.engine.base.Engine.stats

[logger_sqlalchemy](logger_sqlalchemy)
level = INFO
handlers =
qualname = sqlalchemy.engine

[Mike Bayer]

optional, sure. Feel free to provide a patch for this.

[Former user]

What about the attached patch?

[Mike Bayer]

great, that's the idea

[Former user]

Some fixes added.

The patch now does not break existing code (the old patch was broken, I have overridden it).

This still needs a patch to update the documentation and a test suite. As for the test suite, unfortunately I have no idea how this feature should be tested.

[Former user]

Perhaps the ident attribute in the Engine and Pool should default to :

  hex(id(self))

or, to follow current code,

  '0x...%s' % hex(id(self))[-4:](-4:)

instead of None ?

Should we use a function, instead of an attribute?

[Mike Bayer]

5f1fbf575915470391c5a816d99a742e64b6be25

[Mike Bayer]

Removing milestone: 0.6.0 (automated comment)