- attached oursql.patch
Add oursql driver layer for sqlalchemy
A new mysql driver approaches!
I wrote oursql to be a better mysql driver for python, and now I've created this sqlalchemy layer for it. It seems to pass all of the unit tests when running against a mysql 5.1 server.
Comments (11)
-
Account Deleted -
Account Deleted Oh, including the change to test/orm/test_relationships.py was mostly a mistake. It fails without that change on oursql, and I wasn't clear on why it wasn't ordering by id anyway.
-
repo owner I've adjusted that test. The only failures I get are on
test.orm.test_unitofwork.UnicodeTest
. I'd like to also address thatisinstance()
you have to be in a slightly less critical area since those are expensive.looks great ! 9911443b9d0b3df0c1d2a0996a6858b1a4fa9ca0.
-
Account Deleted - attached oursql2.patch
Patch against sqlalchemy trunk, r6511
-
Account Deleted Okay, here's a new version that implements plain queries in a much more sensible way, passing metadata through the Connection object.
If you're getting failures with unicode-related unit tests, make sure that the database charset is utf8. I'm not getting any unicode-related failures when I run the test suite, but I am getting some errors related to two-phase transactions timing out. If you're not getting any such errors, I'll have to figure out what the difference between our testing setups is.
-
repo owner this shouldn't be there:
contextual_connect(close_with_result=True)
that's going to force the DBAPI connection closed even if its being used for a larger set of operations.
-
Account Deleted Oh, I just was duplicating what was in the 'execute' method of the Engine.
-
Account Deleted It passes all unit tests here. sa beta rev 6517, python 2.6 + mysql 5.0.84
-
repo owner Oh I get it, you might be passed an
Engine
there, OK. -
repo owner - changed status to resolved
patch is in and marked a few tests for skip in 404be6e76155a5ef48f3d4a2c1a7e5538de135e9. new oursql issues can come in separate tickets. Great job !
-
repo owner - removed milestone
Removing milestone: 0.6.0 (automated comment)
- Log in to comment
Patch against sqlalchemy trunk, r6491