- attached pre-fix_session.txt
Detect pre-release postgresql versions
While trying out SQLAlchemy 0.6 from trunk, svn revision 6552, with a developement version of PostgreSQL, git commit 84775b16ed1e40b1561adbfdada6c7c68233a73d, I found that SQLAlchemy does not correctly parse pre-release version strings.
AssertionError: Could not determine version from string 'PostgreSQL 8.5devel on x86_64-unknown-linux-gnu, compiled by GCC gcc (GCC) 4.4.2, 64-bit'
I have attached a traceback and a simple patch for this particular case of the regex.
Comments (7)
-
Account Deleted -
Account Deleted A simple PostgreSQL version detection patch
-
Account Deleted I have now confirmed that using psycopg2 produces the same results.
For further reference, the pg8000 version was git commit 20b09b92cfd524181f947970026a9493c2cabc9e and the psycopg2 version was 2.0.13.
-
repo owner - changed milestone to 0.6.0
-
repo owner this should be ported into 0.5 as well, even though its less critical there. a unit test in test/dialect/test_postgresql.py would be along the lines of:
testing.db.dialect.server_version_info("8.5devel"), testing.db.dialect.server_version_info("foo bar")
etc. -
repo owner - changed status to resolved
2698c8facbdb3e7fdb04d933a6541fc4bcc71cf6
not worried about 0.5 for now.
-
repo owner - removed milestone
Removing milestone: 0.6.0 (automated comment)
- Log in to comment
Example session before the patch