[0.6.0] minor performance improvement and correction to BufferedResultProxy
Issue #1787
resolved
The included patch corrects a minor thinko in BufferedResultProxy and also improves performance a little bit (the larger the result set the bigger the performance gain).
Would appreciate feedback!
Comments (5)
-
repo owner
-
Account Deleted
I've been using this in development with postgresql (psycopg2 2.0.14). I'll try to verify that the testing hits the code.
-
repo owner
- changed milestone to 0.7.0
evaluate this for 0.7.0
-
repo owner
- changed status to resolved
looks good, 637fdd32510c7e04dbf279482057f3fa19c97456
-
repo owner
- removed milestone
Removing milestone: 0.7.0 (automated comment)
- Log in to comment
looks pretty good, can you confirm that our current test coverage hits all of these ? I'm not sure if we have tests for them which are independent of running on PG or Oracle, it would help if we did. We have some "result proxy" tests in test/engine/test_execute.py that would be a good place to put them.