Firebird dialect lacks character set support

[Former user]

The firebird dialect does not support character sets despite the underlying database doing so.

I am attaching a patch to make it do so

Winston Ewert

[Former user]

patch to implement charset attribute along with tests

[Mike Bayer]

pretty good patch, I gather you imitated the approach in the MySQL dialect.

[Former user]

Yes.

[Mike Bayer]

This is in 77c3bb26c29c491c1094427345ca51f309938572.

Regarding the patch, for some reason "patch" thought it was invalid, had to do it by hand. Simplified the test for the rendering of the types. Also not sure what the "create()" with trapping the error was for - we usually use assert_raises() for that, but I didn't see the rationale for why the table create should raise and also CompileTest is intended to run even if the firebird DBAPI is not installed, so took that out.

[Mike Bayer]

Removing milestone: 0.6.2 (automated comment)