overhaul metadata table storage, apply to declarative

[Mike Bayer]

diff -r 1402a608ebc28031ce11dec9ed6a90785f09294d lib/sqlalchemy/ext/declarative.py
--- a/lib/sqlalchemy/ext/declarative.py Wed Aug 25 11:01:46 2010 -0400
+++ b/lib/sqlalchemy/ext/declarative.py Wed Aug 25 19:19:35 2010 -0400
@@ -1173,6 +1173,8 @@
                 return _GetColumns(cls._decl_class_registry[key](key))
             elif key in cls.metadata.tables:
                 return cls.metadata.tables[key](key)
+            elif key.replace("_", ".") in cls.metadata.tables:
+                return cls.metadata.tables[".")](key.replace("_",)
             else:
                 return sqlalchemy.__dict__[key](key)

[Mike Bayer]

so attached is a patch that hacks this out in a way I don't really like. Here's what I want, and it will be 0.7:

m = MetaData()

t1 = Table('foo', m, ..., schema="x")
t2 = Table('bar', m, ...)

assert m.tables.bar is t2
assert m.tables.x.foo is t1

# old interface works for reads:
assert m.tables['bar']('bar') is t2
assert m.tables['x.foo']('x.foo') is t1

# and this
assert m.tables['x']('x')['foo']('foo') is t1

So ".tables" becomes just like ".columns". Its a dict/prop interface that is definitely not mutable (its almost like OrderedProperties but I don't want it to have an ordering to start and i really dont want any mutators on it, so make it something new). remove() as always will remove a table.

[Mike Bayer]

unfortunately that idea breaks for tablename + schemaname are the same. so next idea:

m.schemas.x.foo
m.tables.bar

for declarative, not sure if there's any real solution here.

[Mike Bayer]

Patch has been updated, leaving mostly the original scheme in place, except metadata.tables becomes a frozendict. Changing my mind regarding fancy schema.table accessors for now.

[Mike Bayer]

diff:@2336b1cebfcb2f304e09cbc2a0e8bb3fb3a9ceeb:08e5c35c2dd6ee3344bfe9077c6036a182baf5c8

[Mike Bayer]

Removing milestone: 0.7.0 (automated comment)