- changed title to deprecate tuple form of query.join(), replace with 2-arg form
add 2-arg form to query.join(), supercedes tuple form (but don't deprecate)
Issue #1923
resolved
this involves working out the logic to detect the "old" calling style and test heavily.
the "three arg" form, (left, right, onclause), can be released after 0.7.0.
Comments (7)
-
reporter -
reporter this is a very easy change and most of the work involves changing the tests, patch is attached.
-
reporter change the deprecation warning to pending deprecation. the current calling style shouldn't produce warnings for 0.7.
-
reporter -
reporter the ORM tutorial is not up to date yet, still says "we use a tuple", probably shouldn't talk about the tuple form for now
-
reporter - changed status to resolved
-
reporter - removed milestone
Removing milestone: 0.7.0 (automated comment)
- Log in to comment