add 2-arg form to query.join(), supercedes tuple form (but don't deprecate)

Issue #1923 resolved
Mike Bayer repo owner created an issue

this involves working out the logic to detect the "old" calling style and test heavily.

the "three arg" form, (left, right, onclause), can be released after 0.7.0.

Comments (7)

  1. Mike Bayer reporter

    this is a very easy change and most of the work involves changing the tests, patch is attached.

  2. Mike Bayer reporter

    change the deprecation warning to pending deprecation. the current calling style shouldn't produce warnings for 0.7.

  3. Mike Bayer reporter

    the ORM tutorial is not up to date yet, still says "we use a tuple", probably shouldn't talk about the tuple form for now

  4. Log in to comment