mapper compilation
-
removedeprecate mapper.compile() -
compile_mappers() becomes "configure_mappers()", old name is silly.
-
"configure_mappers()" no longer is a loop through mappers, calling each compile(), which is then a loop anyway, this is also silly, it moves into mapper.py and gains the body of mapper.compile().
-
remove most calls to mapper.compile().Replace each mapper.compile() call with an inline check for "_new_mappers", then call to "configure_mappers()" if True.at strategic locations within mapper.py, elsewhere, perhaps upon query() and in the usual get_properties() types of places.
5. the "compile_mappers" flag in get_property() should be removed, the check for "compiling" should be smart enough (thought it already was) to realize reentrant access and return. (why does the "_already_compiling" check return None?)
Comments (3)
-
reporter -
reporter - changed status to resolved
diff:@2336b1cebfcb2f304e09cbc2a0e8bb3fb3a9ceeb:6dfbe839aaf026e72ecb079fc7608ad6c09babf8
-
reporter - removed milestone
Removing milestone: 0.7.0 (automated comment)
- Log in to comment
patch is attached, this came out great, cuts down function calls, and is ready to go