mapper compilation

Issue #1966 resolved
Mike Bayer repo owner created an issue
  1. remove deprecate mapper.compile()

  2. compile_mappers() becomes "configure_mappers()", old name is silly.

  3. "configure_mappers()" no longer is a loop through mappers, calling each compile(), which is then a loop anyway, this is also silly, it moves into mapper.py and gains the body of mapper.compile().

  4. remove most calls to mapper.compile(). Replace each mapper.compile() call with an inline check for "_new_mappers", then call to "configure_mappers()" if True. at strategic locations within mapper.py, elsewhere, perhaps upon query() and in the usual get_properties() types of places.

5. the "compile_mappers" flag in get_property() should be removed, the check for "compiling" should be smart enough (thought it already was) to realize reentrant access and return. (why does the "_already_compiling" check return None?)

Comments (3)

  1. Log in to comment