- changed status to resolved
flush post-accounting shouldn't operate on expiered instances when autocommit=True
Issue #2041
resolved
post-flush emits a SELECT for every row otherwise
Comments (5)
-
reporter -
reporter - removed status
- changed status to open
I think I might want to try lifting the original limitation here, move the flush accounting inside the autocommit transaction .
-
reporter -
reporter - changed status to resolved
Moved the post flush as well as the event hook into the try/except block in 8f381f202e569eda0d5de13f584304440492222c. The change to autoflush=False is that the accounting + the hook are inside the scope of where rollback() would be called. There's a potential for backwards incompatible here if people have post_flush_exec hooks that either throw exceptions or call rollback(). Let's see how it goes.
-
reporter - removed milestone
Removing milestone: 0.7.0 (automated comment)
- Log in to comment
ae5b58d9a5b03b71d2c22d410d1d94f8361b99f0