Inconsistent keyword arg naming between alias() and FromClause.alias()
Issue #2124
resolved
Where table
is an instance of Table
,
alias(table, alias = 'othername')
is equivalent to
table.alias(name = 'othername')
Why is the keyword argument called alias
in the first case but name
in the second?
I would propose that name
is the more intuitive choice here and that the alias()
function and Alias.__init__
should call it name
instead of alias
, with alias
also accepted but deprecated.
I only tested this in SQLA .66, so I don't know if this has changed somehow already in .7
Comments (2)
-
repo owner -
repo owner - removed milestone
Removing milestone: 0.7.0 (automated comment)
- Log in to comment
this was fixed in 0.7 and is mentioned at http://www.sqlalchemy.org/trac/wiki/07Migration#Renamedthealiaskeywordargofstandalonealiasfunctiontoname , 7ac30f96b9f506ef4ab34e1c725bf6911a6c22fb.