column selection in nested selects overzealously skips down the chain of labels

[Mike Bayer]

which means nothing. here's what it means:

from sqlalchemy.sql import table, column, select

t1 = table('t1', column('a'), column('b'))

s = select([   select([(t1.c.a + t1.c.b).label('q')](
)).label('y'),
])

#assert s.c.q is not None
assert s.c.y is not None

it puts it in as "q" and not "y". very strange ! At the ORM level you can test this via column_property() derived from another column_property().

[Mike Bayer]

wow this is a really odd bug to have at this stage in the game, that this never came up before.

diff -r aea4b9928e99b04237f61aeccbeb31c02367a2c0 lib/sqlalchemy/sql/expression.py
--- a/lib/sqlalchemy/sql/expression.py  Sat May 14 14:31:29 2011 -0400
+++ b/lib/sqlalchemy/sql/expression.py  Wed May 18 01:21:51 2011 -0400
@@ -3815,7 +3815,7 @@

     def _make_proxy(self, selectable, name = None):
         if isinstance(self.element, (Selectable, ColumnElement)):
-            e = self.element._make_proxy(selectable, name=self.name)
+            e = self.element._make_proxy(selectable, name=name or self.name)
         else:
             e = column(self.name)._make_proxy(selectable=selectable)

that's it !

[Mike Bayer]

here's an ORM test too:

from sqlalchemy import *
from sqlalchemy.orm import *
from sqlalchemy.ext.declarative import declarative_base

Base = declarative_base()

class Author(Base):
   __tablename__ = 'authors'

   id = Column(Integer, primary_key=True)

   first_name = Column(String(50), nullable=False)
   last_name = Column(String(50), nullable=False)

   name = column_property((first_name + ' ' + last_name).label('name'))

class Book(Base):
   __tablename__ = 'books'

   id = Column(Integer, primary_key=True)
   author_id = Column(Integer, ForeignKey('authors.id'))
   author_name = column_property(
       select(
           [Author.name](Author.name),
           author_id == Author.id,
       ).label('author_name')
   )

e = create_engine('sqlite://', echo=True)
Base.metadata.create_all(e)

s = Session(e)
s.query(Book).from_self().all()

[Mike Bayer]

00380cf3c304ea7f1c7397f17b828166364c36ac 94fc44ac020da38e29340955e9cb696133080a03

[Mike Bayer]

Removing milestone: 0.6.8 (automated comment)