MapperExtension's append_result and populate_instance's docs/API are incorrect
Issue #220
resolved
The docs (or is it the API) for both of these extension functions are incorrect. The docs say:
If this method returns True, it is assumed that the mapper should do the appending, else
if this method returns False, it is assumed that the append was handled by this method.
The code actually expects these functions to return sqlalchemy.orm.mapper.EXT_PASS to notify the mapper should do the appending, and anything else assumes the append was handled by the extension method
There may be others that are also doing the wrong thing (probably create_instance)
Comments (4)
-
repo owner -
repo owner - changed milestone to 0.3.0
- removed version
always me me me.....
-
repo owner - changed status to resolved
the recent refactoring of mapper.instances() has fixed this (although the API has changed...)
-
repo owner - removed milestone
Removing milestone: 0.3.0 (automated comment)
- Log in to comment
yah the ME docs have fell by the wayside a bit....would you have time to go through the method docs and submit a patch for me ? else ill try to get to this....