FlushError even if no SQL statement will be emitted and allow_partial_pks is True

[Former user]

See http://www.sqlalchemy.org/trac/ticket/2127#comment:9 for history.

[Former user]

I know you were leaning toward only raising if you have determined there is something to update. The alternative in my mind is only raise if ... and not mapper.allow_partial_pks:

                                if value is None and not mapper.allow_partial_pks:
                                    raise sa_exc.FlushError(
                                                "Can't update table "
                                                "using NULL for primary "
                                                "key value")

[Mike Bayer]

1f057987da6ee5ca6da94384a0603e4fee13dff8 only raises if there's something to update. actually supporting "UPDATE...WHERE .. x IS NULL", I'm not too keen on that. let me know if this solves your issue.

Also I'm ready to break up _save_obj() and _delete_obj() into smaller methods as their length is starting to become embarrassing.

[Former user]

Replying to zzzeek:

1f057987da6ee5ca6da94384a0603e4fee13dff8 only raises if there's something to update. actually supporting "UPDATE...WHERE .. x IS NULL", I'm not too keen on that. let me know if this solves your issue.

I'm sure this will solve the issue, thanks !

[Mike Bayer]

Removing milestone: 0.7.6 (automated comment)