deprecate inspector.get_primary_keys() ?
this method is redundant vs. get_pk_constraint() and also not named very well. All the dialects could just as well just implement get_pk_constraint() internally too. The method doesn't seem to be used by itself.
Comments (7)
-
reporter -
Account Deleted (original author: diana) Replying to zzzeek:
looks great. I think we want to leave inspector.get_primary_keys() in, mark with @deprecated for now, in case anyone is using it.
Ok. I'll add it back... Friday night (busy until then). And then re-submit. Thx!
-
Account Deleted - changed watchers to diana
(original author: diana)
-
Account Deleted (original author: diana) Toying with pull requests instead of patches.
https://bitbucket.org/sqlalchemy/sqlalchemy/pull-request/3/deprecate-inspectorget_primary_keys-in
-
reporter 1fe06a551c28a6e0886f96334deebdee68d9fff9 in the 0.8 branch
-
reporter - changed status to resolved
-
reporter - removed milestone
Removing milestone: 0.8.0b1 (automated comment)
- Log in to comment
looks great. I think we want to leave inspector.get_primary_keys() in, mark with @deprecated for now, in case anyone is using it.