PostgreSQL multi-column primary keys reflected in wrong order

[Former user]

The reflection query for primary keys on PostgreSQL returns the correct column names, but ordered as they appear in the table, which is not necessarily the way they are ordered in the key.

Attaching a patch with a test that exhibits the problem, and a new query that corrects it. The new query also drops the unnecessary join to pg_class, but adds a subquery unnesting the key order (I didn't find an obvious way to do this without the subquery). I doubt this is any slower, but I haven't measured.

[Former user]

Patch against rel_0_7

[Former user]

Patch against default branch

[Former user]

Updated patches to apply cleanly after recent conflicting whitespace cleanup.

[Mike Bayer]

had to put version detection in this with the old query as a fallback, as unnest() and generate_subscripts() are only in PG's docs for version 8.4 and forward.

thanks for the patches !

e1d09859c55576f507e75960504719d17a46779c

2e72b91a0c179fda023b0487a8922fc2a1705d2a

[Former user]

Sure. You didn't include the test though ... was that deliberate? Reattaching as a separate patch if you want it, with @testing.fails_if(('postgresql', '<', (8, 4))) added.

[Former user]

Patch against rel_0_7 adding a test

[Former user]

Well that was a nice bout of brain flatulence I just had. You did include the test. Please disregard. :)

[Mike Bayer]

Removing milestone: 0.7.9 (automated comment)