Invalid SQL emitted for over(partition_by=[]) and over(order_by=[])

For queries like this:

select([func.sum(tab.c.id).over(partition_by=[](func.sum(tab.c.id).over(partition_by=[))])

invalid SQL is emitted:

SELECT sum(foo.id) OVER (PARTITION BY ) AS anon_1 
FROM foo

Passing empty lists has a reasonably well defined meaning (don't partition/order by anything), and may arise as a consequence of code like partition_by=list(determine_partition_expressions()), where restructuring the code to not pass the parameter if its value will be empty is an unnecessary inconvenience.

Submitting a patch with tests.

Comments (11)