drop_all(tables=[]) doesn't work

[Andrew Lutomirski]

The bug is trivial: SchemaDropper starts out as like this.

class SchemaDropper(DDLBase):
    def __init__(self, dialect, connection, checkfirst=False, tables=None, **kwargs):
        super(SchemaDropper, self).__init__(connection, **kwargs)
        self.checkfirst = checkfirst
        self.tables = tables
        self.preparer = dialect.identifier_preparer
        self.dialect = dialect
        self.memo = {}

    def visit_metadata(self, metadata):
        if self.tables:
            tables = self.tables
        else:
            tables = metadata.tables.values()

That should be {{{if self.tables }}}''{{{is not None}}}''

See source:/lib/sqlalchemy/engine/ddl.py#L120

[Andrew Lutomirski]

create_all has the same problem.

[Mike Bayer]

I'm probably going to keep this in 0.8 as it might change the behavior of an 0.7 app that's unknowningly relying upon it.

[Mike Bayer]

trivial change, but the testing/documentation fanfare surrounding it, not so much, as ddl.py wasn't independently covered. Extra notes added to the changelog/migration for this late-add behavioral change. 6ddfe3b390fac8e5c7ef633ad5dd67463e94443b

[Mike Bayer]

Removing milestone: 0.8.0final (automated comment)