add "permanent=True" flag to session.close()
Issue #2706
resolved
I think the idea of Session.close() allowing the session to spring back to life again causes more problems than it solves, e.g. http://stackoverflow.com/questions/15881439/sqlalchemy-not-closing-sessions-with-orm/15938093. If we add a flag "permanent=True" and document that, users can have a "close this session and please don't allow my code to use it again" behavior, since I think that's probably what people would prefer (i.e. close() should have been this way all the time, too late for that though).
Comments (5)
-
reporter -
reporter - marked as major
-
reporter this shoudl be a session config setting:
session(close_permanent=True)
-
reporter - changed status to wontfix
like
#2760im not really getting excited about this. we can reopen if we want to revisit at some point -
reporter - removed milestone
Removing milestone: 0.8.xx (automated comment)
- Log in to comment
testing email