1. Mike Bayer Avatar Mike Bayer
  2. Untitled project
  3. sqlalchemy_old
  4. Issues

ability to send in EagerRowAdapter / disable eager row adapting via instances()

Issue #347 resolved
Mike Bayer repo owner created an issue

so that a hand-constructed eager query can be used with instances()

Comments (3)

  1. Mike Bayer reporter
    • changed milestone to 0.3.1

    changeset:2010 contains a rudimental form of this. however, it should be further improved so that using instances() by default means that no eager aliasing rules will be applied to the rows (this would require some communication between the QueryContext and SelectionContext). row decoration should only take place if the contains_eager() option specifies a row decorator function, or if some message was passed from the QueryContext.

  2. Mike Bayer reporter

    ok, the extra step of having no eager aliasing rules by default doesnt work; as the eager loader may come across a row that seems like it contains an eager-loaded instance, but actually doesnt, and it fails to degrade to a lazy relationship. this occurs in the test/orm/poly_linked_list.py set of tests. so the "clue" that "hey, this query contains this attribute eager loaded" is needed, and the 2010 version is the correct approach.

  4. Log in to comment
Assignee
Type
enhancement
Priority
major
Status
resolved
Component
(none)
Milestone
–
Votes
0
Watchers
0
Jira: the preferred issue tracker for Bitbucket. Join the team!