AttributeError in WithinGroup

Issue #4012 resolved
Scott Milliken created an issue

Commit 7c4512c did a refactor, renaming the WithinGroup constructor argument from func to element. It looks like a reference to func in WithinGroup.get_children didn't get updated.

Noticed because it's causing an AttributeError when trying to use func.percentile_cont.

Comments (3)

  1. Mike Bayer repo owner

    WithinGroup was added for the first time in that changeset, nothing was "renamed" directly there. I can see that the wrong name is referred to inside of get_children(), however.

    I've spent about ten minutes trying to come up with a real-use style case that actually invokes get_children() for WithinGroup so can you please complete the bug report here with an MCVE and complete stack trace as required in the guidelines? thanks.

  2. Mike Bayer repo owner

    Repair WithinGroup.get_children()

    Fixed AttributeError which would occur in :class:.WithinGroup construct during an iteration of the structure.

    Change-Id: I563882d93c8c32292463a605b636aa60c77e9406 Fixes: #4012

    → <<cset 3a314fcea853>>

  3. Log in to comment