Select object needs copy_container()
Issue #52
resolved
some compilation/mapper steps want to take an incoming Select statement and modify it before compiling/continuing compilation. Particularly for some tweaks in the Oracle module where it makes life a lot easier to modify the Select and send it down to the base ansisql module, rather than re-implementing all of visit_select().
The point is, when it wants to modify a select it should be creating a copy of the select and operating upon that, so that the original is untouched. So we need copy_container() fully implemented on the select object (and also CompoundSelect)....and it should run fast !
Comments (4)
-
reporter -
reporter - changed milestone to 0.4.0
this feature is also needed in order to allow
ClauseAdapter
to work withSelect
objects, i.e. blocks#569. -
reporter - changed status to resolved
-
reporter - removed milestone
Removing milestone: 0.4.0 (automated comment)
- Log in to comment
additionally, some tests in test/sql to ensure that the copied selectable produces identical sql to its original.
this is not a hard ticket at all but just requires some completeness.