engine_from_config does not convert max_overflow and pool_size to ints

[Former user]

engine_from_config does not convert max_overflow and pool_size to int's. Some other options should probably be considered to be added there?

Here's a patch:

Index: __init__.py
===================================================================
--- __init__.py (revision 3416)
+++ __init__.py (working copy)
@@ -179,6 +179,8 @@
         ('echo', bool),
         ('echo_pool', bool),
         ('pool_recycle', int),
+        ('pool_size', int),
+        ('max_overflow', int),
     ):
         util.coerce_kw_type(opts, opt, type_)
     opts.update(kwargs)

[Former user]

I also got caught by this. Can we get it in the next beta since it's such a trivial change? This prevents Pylons users from putting those options in their config file.

pool_timeout is also documented to be an int.

[Former user]

All available options should be taken care and "casted" to the type they should be.

[jek]

Added pool_size and max_overflow to the "select set" of coerced arguments in 3d9d21cc14982654cadd7678d44e14df62d812d2. Full coverage with dialect- and pool-specific arguments is still a future feature.

[Mike Bayer]

Removing milestone: 0.4.0 (automated comment)