python 2.3 compatability for 0.4.2p3
Python 2.3 compatability appears to be an easy add, easy win here. Python 2.3 is the default on RHEL4 and is still very widely deployed.
diff -ur SQLAlchemy-0.4.2p3.orig/lib/sqlalchemy/orm/query.py SQLAlchemy-0.4.2p3/lib/sqlalchemy/orm/query.py --- SQLAlchemy-0.4.2p3.orig/lib/sqlalchemy/orm/query.py 2008-01-09 15:38:36.000000000 -0600 +++ SQLAlchemy-0.4.2p3/lib/sqlalchemy/orm/query.py 2008-01-29 09:45:44.000000000 -0600 @@ -837,7 +837,7 @@ if tuples: rows = util.OrderedSet() for row in fetch: - rows.add(tuple(proc(context, row) for proc in process)) + rows.add(tuple(row) for proc in process) else: rows = util.UniqueAppender([ for row in fetch: diff -ur SQLAlchemy-0.4.2p3.orig/lib/sqlalchemy/orm/dependency.py SQLAlchemy-0.4.2p3/lib/sqlalchemy/orm/dependency.py --- SQLAlchemy-0.4.2p3.orig/lib/sqlalchemy/orm/dependency.py 2008-01-09 15:38:36.000000000 -0600 +++ SQLAlchemy-0.4.2p3/lib/sqlalchemy/orm/dependency.py 2008-01-29 09:46:06.000000000 -0600 @@ -282,7 +282,7 @@ self._process_key_switches(deplist, uowcommit)
def _process_key_switches(self, deplist, uowcommit):
- switchers = util.Set(s for s in deplist if self._pks_changed(uowcommit, s))
- switchers = util.Set(s for s in deplist if self._pks_changed(uowcommit, s) )) if switchers: # yes, we're doing a linear search right now through the UOW. only # takes effect when primary key values have actually changed.
Comments (2)
-
repo owner -
- changed status to resolved
closing this, the trunk passes the tests 100% on 2.3. key changesets were 4be99db15b7a62b37493c86da07bcc787f44a7df, 412c80dd6c5d6b940e86e7e142aa1fdd6ee4466d, b3cc2f7e0c308354f3f939c47c382a2d11845d4f
- Log in to comment
hi, please try out the SVN trunk. jek has made plenty of changes recently to re-introduce support for python 2.3.