Couldn't prepare data for creation layout

[Former user]

Pattern last modified 20th of March 2018. Loaded into Valentina Git:1e6d070.

It's the same pattern used to debug Issue #842. I can re-send off-tracker if required.

When trying to create a 42" roll layout it shows a "Couldn't prepare data for creation layout" message and does not create layout.

Also tested in earlier builds that definitely used to work and the same problem appears.

[2018.05.21 06:55:59:DEBUG:../../../../src/app/valentina/xml/vpattern.cpp(309)] void VPattern::setCurrentData(): v.xml: Data successfully updated.
[2018.05.21 06:55:59:DEBUG:../../../../src/app/valentina/mainwindow.cpp(2685)] void MainWindow::ActionLayout(bool): v.mainwindow: Show layout scene
[2018.05.21 06:55:59:DEBUG:../../../../src/libs/vlayout/vabstractpiece.h(248)] static QVector<T> VAbstractPiece::CorrectEquidistantPoints(const QVector<T> &, bool) [T = QPointF]: default: Only three points.
[2018.05.21 06:55:59:DEBUG:../../../../src/libs/vlayout/vabstractpiece.h(248)] static QVector<T> VAbstractPiece::CorrectEquidistantPoints(const QVector<T> &, bool) [T = VSAPoint]: default: Only three points.
[2018.05.21 06:55:59:DEBUG:../../../../src/libs/vlayout/vabstractpiece.h(248)] static QVector<T> VAbstractPiece::CorrectEquidistantPoints(const QVector<T> &, bool) [T = VSAPoint]: default: Only three points.
[2018.05.21 06:55:59:DEBUG:../../../../src/libs/vlayout/vabstractpiece.h(248)] static QVector<T> VAbstractPiece::CorrectEquidistantPoints(const QVector<T> &, bool) [T = VSAPoint]: default: Only three points.
[2018.05.21 06:55:59:DEBUG:../../../../src/libs/vlayout/vabstractpiece.h(248)] static QVector<T> VAbstractPiece::CorrectEquidistantPoints(const QVector<T> &, bool) [T = VSAPoint]: default: Only three points.
[2018.05.21 06:56:09:DEBUG:../../../../src/libs/vlayout/vabstractpiece.h(248)] static QVector<T> VAbstractPiece::CorrectEquidistantPoints(const QVector<T> &, bool) [T = VSAPoint]: default: Only three points.
[2018.05.21 06:56:09:DEBUG:../../../../src/libs/vlayout/vabstractpiece.h(248)] static QVector<T> VAbstractPiece::CorrectEquidistantPoints(const QVector<T> &, bool) [T = QPointF]: default: Only three points.
[2018.05.21 06:56:09:DEBUG:../../../../src/libs/vlayout/vbank.cpp(208)] bool VBank::Prepare(): layout.bank: Preparing data for layout error: Detail squere <= 0
[2018.05.21 06:56:09:CRITICAL:../../../../src/app/valentina/dialogs/dialoglayoutprogress.cpp(92)] void DialogLayoutProgress::Error(const LayoutErrors &): default: "Couldn't prepare data for creation layout"

Suspecting local settings problem but not sure what. Will attach Layout settings screenshot as well.

[Former user]

Also tested with rotating pieces by 2 degrees, same problem.

[Roman Telezhynskyi]

This is issue with one of pieces.

I can re-send off-tracker if required.

I just checked your pattern. On my side all works just fine. You can debug the place and find out which piece causes the error in your case. Also i'll try to reproduce on Mac.

[Former user]

The pattern hasn't changed since March (modification date) and I was able to create layouts back then. The earlier releases seem to have the same problem even if they worked fine back then.

I suspect my config file. I've sent ~/.config/ValentinaTeam your way as a tarball.

[Roman Telezhynskyi]

Confirm. With your config one of pieces has no shape.

[Former user]

Patched vbank.cpp to:

            qCDebug(lBank, "Preparing data for layout error: Detail square <= 0 %u", i);

Built. Loaded .val and entered Layout.

Got piece number 22 in the debug message.

[Roman Telezhynskyi]

This is issue with global curve approximation value. Make it lower (0.5) to see your piece.

[Former user]

Confirmed. With 0.5 it generates layout. Thank you!

Is it possible to add some safety checks or a more meaningful error message to suggest that?

Also, completely trivial, s/squere/square/g.

[Roman Telezhynskyi]

Is it possible to add some safety checks or a more meaningful error message to suggest that?

This is bug in VAbstractCurve::GetSegmentPoints.

[Roman Telezhynskyi]

This is correctly working an order.

[Roman Telezhynskyi]

I close this issue since it is an example of "Main path rule". Valentina treats first loop it incounter as main path and cuts all others. Making less points with curve approximation 0.5 change the path and thus change a configuration. This is pure lack that the configuration works in such configuration.

[Roman Telezhynskyi]

Fix typo. ref #850.

→ <<cset b2eabb19f8fc>>

[Roman Telezhynskyi]

Improve the debug message. It can contains a piece name. ref #850.

→ <<cset 4a366e92b045>>

[Former user]

This is pure luck

Story of my life! ;) Thank you for looking into it!

[Former user]

Oh, and confirmed, moving W23 to the end makes the layout work even with curve approximation at 2. I'll keep it at 0.5 anyway. Thanks again.